Skip to content

create separate list of collection search extensions #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 9, 2024
Merged

create separate list of collection search extensions #158

merged 4 commits into from
Oct 9, 2024

Conversation

@hrodmn
Copy link
Collaborator

@hrodmn hrodmn commented Oct 8, 2024 •
edited
Loading

Related Issue(s):

Description:

Since only a subset of extensions can be combined with the collection search extension we need to keep a separate list.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

@hrodmn hrodmn requested a review from vincentsarago October 8, 2024 14:40
vincentsarago
vincentsarago reviewed Oct 8, 2024
View reviewed changes
@vincentsarago

This comment was marked as resolved.

Sign in to view
@vincentsarago

This comment was marked as resolved.

Sign in to view
@vincentsarago vincentsarago merged commit 4321497 into main Oct 9, 2024
7 checks passed
@vincentsarago vincentsarago deleted the patch/split-extensions branch October 9, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vincentsarago vincentsarago vincentsarago approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hrodmn @vincentsarago